-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs_build step #1189
add docs_build step #1189
Conversation
87bd312
to
44c6729
Compare
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1189 +/- ##
============================================
Coverage 0.00% 0.00%
============================================
Files 6 6
Lines 421 421
============================================
Misses 421 421 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ca77e8d
to
ce9ea0f
Compare
ce9ea0f
to
03123a3
Compare
b950da3
to
5a32ed3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few changes suggested
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
The scripts look okay now, but the logs are showing some error codes. I'm not sure why these aren't causing the job to fail. It's possible that the Regardless, we should investigate and try to get them fixed. The entire job log should be scanned for additional error messages besides the ones explicitly shown below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! All looks good to me.
Two follow-up tasks for developers to address in separate PRs:
- drop usage of
recommonmark
because the repo is archived (in favor of MyST) and it's throwing warnings: parser: multiple warning messages due to missing visit_document() method readthedocs/recommonmark#177 - fix the most obvious warnings in the C++ docs (mislabeled parameters, etc.)
/merge |
The PR adds a
docs_build
process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.