Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify include_package_data to setup #1218

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 22, 2023

Description

For pure setuptools-based builds, the include_package_data option historically defaulted to False. With newer projects, i.e. with projects containing a pyproject.toml file, it defaults to True. However, for projects using scikit-build this setting must be provided explicitly to the setup function (not in the config file) to allow scikit-build to intercept the argument and use it in the preprocessing it does before invoking setuptools.setup.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Feb 22, 2023
@vyasr vyasr self-assigned this Feb 22, 2023
@vyasr vyasr requested a review from a team as a code owner February 22, 2023 21:47
@github-actions github-actions bot added the Python Related to RMM Python API label Feb 22, 2023
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit c085cdb into rapidsai:branch-23.04 Feb 22, 2023
@bdice
Copy link
Contributor

bdice commented Feb 22, 2023

I confirmed: conda packages now contain the pxd files.

@vyasr vyasr deleted the fix/include_package_data branch February 22, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants