-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate pyproject.toml dependencies using dfg #1219
Generate pyproject.toml dependencies using dfg #1219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vyas! 🙏
Had a few comments about changes in the pyproject.toml
and whether we can address these in dependencies.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments John. This PR isn't quite ready for prime-time yet, but you did catch a couple of important issues for us to address before it's ready 🙂
Ah sorry. Was mainly excited to see the increased usage of Happy to hold off further review until things are more ready 👍 |
abb0363
to
189552e
Compare
189552e
to
e668179
Compare
@jakirkham this is ready for review now 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure what benefit we are getting from the new sections in dependencies.yaml. See comments.
…t_dependencies_yaml
/merge |
Description
This PR updates dependencies.yaml to also generates the relevant dependency sections of pyproject.toml.
Checklist