Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CUDA 12 dependencies and fix dlopen library names #1366

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 24, 2023

Description

The dropping of system CTK libraries from our CUDA 12 CI images revealed that we were missing the cuda-nvcc package required to provide nvvm for numba in the Python tests. They also revealed that the list of libraries we searched to dlopen is incomplete; for CUDA 11, the SONAME of the library incorrectly includes an extra .0 version segment, and rmm was designed to search for that, but CUDA 12 correctly has just libcudart.so.12 and that needs to be added to the search path. We were previously getting by on finding libcudart.so, but the linker name is only present in conda environments if cuda-cudart-dev is installed, and that package should not be a runtime requirement for rmm.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr self-assigned this Oct 24, 2023
@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Oct 24, 2023
@github-actions github-actions bot added the conda label Oct 24, 2023
@github-actions github-actions bot added cpp Pertains to C++ code and removed conda labels Oct 24, 2023
@github-actions github-actions bot added the conda label Oct 24, 2023
@github-actions github-actions bot added the ci label Oct 24, 2023
@vyasr vyasr changed the title Add missing CUDA 12 dependencies Add missing CUDA 12 dependencies and fix dlopen library names Oct 24, 2023
@vyasr vyasr marked this pull request as ready for review October 24, 2023 22:05
@vyasr vyasr requested review from a team as code owners October 24, 2023 22:05
@vyasr vyasr requested review from rongou and jrhemstad October 24, 2023 22:05
@vyasr
Copy link
Contributor Author

vyasr commented Oct 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit 39800d3 into rapidsai:branch-23.12 Oct 24, 2023
44 checks passed
@vyasr vyasr deleted the fix/cuda_12_deps branch October 24, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci conda cpp Pertains to C++ code non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants