-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CUDA 12.2 #1419
Support CUDA 12.2 #1419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll mark this as DO NOT MERGE until we get more of RAPIDS passing and we decide whether to target 24.02 or 24.04.
We should not use the cuda-cudart-dev package in host as a means of getting a run_export of cuda-cudart in run, because it enforces an equal or greater version of cuda-cudart at runtime. This breaks CUDA minor version compatibility, where we intend to build a package with e.g. CUDA 12.2, and allow it to be run with e.g. CUDA 12.0.
This reverts commit d4f8aa2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that builds and tests appear to be using the correct CUDA versions now. xref: rapidsai/build-planning#8 (comment)
/merge |
Follow-up to #1419 For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows` with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged. ### Notes for Reviewers This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS. For more details see: * rapidsai/build-planning#7 *(created with `rapids-reviser`)* Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #1468
Description
Notes for Reviewers
This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.
For more details see:
Checklist
Notes for Reviewers
Planning a second round of PRs to revert these references back to a proper
branch-24.{nn}
release branch ofshared-workflows
once rapidsai/shared-workflows#166 is merged.