Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor error.hpp out of detail #1439

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Refactor error.hpp out of detail #1439

merged 8 commits into from
Jan 29, 2024

Conversation

lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Jan 26, 2024 •
edited by harrism
Loading

Description

I've moved the public part of error.hpp out of the detail header as described in #1369

Fixes #1369

@lamarrr lamarrr requested a review from a team as a code owner January 26, 2024 14:06
@lamarrr lamarrr requested review from harrism and miscco January 26, 2024 14:06
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the cpp Pertains to C++ code label Jan 26, 2024
miscco
miscco approved these changes Jan 26, 2024
View reviewed changes
include/rmm/error.hpp Outdated Show resolved Hide resolved
@lamarrr @miscco
Update include/rmm/error.hpp
305d0b4 
Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
wence-
wence- approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, a minor style fix.

include/rmm/detail/error.hpp Outdated Show resolved Hide resolved
@wence- wence- added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 26, 2024
@wence-
Copy link
Contributor

wence- commented Jan 26, 2024

/ok to test

@harrism harrism changed the title refactored error.hpp out of detail Refactor error.hpp out of detail Jan 26, 2024
@harrism
Copy link
Member

harrism commented Jan 26, 2024

Need to extend the copyright to 2024 on the original header. Otherwise good to go.

@harrism harrism changed the base branch from branch-24.02 to branch-24.04 January 26, 2024 21:15
@harrism
Copy link
Member

harrism commented Jan 26, 2024

Changed to correct target branch.

@wence-
Fix copyright
48f828f 
We must include the copyright range.
@wence-
Copy link
Contributor

wence- commented Jan 29, 2024

/ok to test

harrism
harrism reviewed Jan 29, 2024
View reviewed changes
include/rmm/error.hpp Outdated Show resolved Hide resolved
harrism
harrism approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lamarrr !

@harrism
Copy link
Member

harrism commented Jan 29, 2024

/ok to test

@harrism
Copy link
Member

harrism commented Jan 29, 2024

/merge

@rapids-bot rapids-bot bot merged commit f259b88 into rapidsai:branch-24.04 Jan 29, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@miscco miscco miscco approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Move error.hpp out of detail
4 participants
@lamarrr @wence- @harrism @miscco