Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure update-version.sh preserves alpha specs #1572

Merged
merged 1 commit into from
May 30, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31

Follow-up to #1502

  • ensures that update-version.sh does not remove alpha specs like ,>=0.0.0a0 in pyproject.toml and conda environment files
  • consolidates rapids-build-backend versions in dependencies.yaml

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Notes for Reviewers

Shouldn't this also be adding a test on the __git_commit__ and __version__ constants?

I'd said previously that I didn't include that in #1502, but looks like I actually did:

def test_version_constants_are_populated():

@jameslamb jameslamb added 3 - Ready for review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 29, 2024
@jameslamb jameslamb requested review from a team as code owners May 29, 2024 22:27
@jameslamb jameslamb removed the 3 - Ready for review Ready for review by team label May 30, 2024
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 805bcf1 into rapidsai:branch-24.08 May 30, 2024
57 checks passed
@jameslamb jameslamb deleted the more-rbb branch May 30, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants