Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs cross reference in DeviceBuffer.prefetch #1636

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Fix docs cross reference in DeviceBuffer.prefetch #1636

merged 3 commits into from
Aug 5, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 1, 2024

Description

Closes #1635.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner August 1, 2024 13:14
@github-actions github-actions bot added the Python Related to RMM Python API label Aug 1, 2024
@bdice bdice added doc Documentation non-breaking Non-breaking change Python Related to RMM Python API and removed Python Related to RMM Python API labels Aug 1, 2024
@bdice bdice mentioned this pull request Aug 1, 2024
Merged
3 tasks
@jakirkham jakirkham requested a review from leofang August 1, 2024 18:29
@leofang
Copy link
Member

leofang commented Aug 1, 2024

Hmmm... I wonder what's wrong

docstring of rmm._lib.device_buffer.DeviceBuffer.prefetch:10: ERROR: Unknown interpreted text role "py".

https://github.com/rapidsai/rmm/actions/runs/10199058213/job/28215990143?pr=1636#step:9:1264

bdice and others added 2 commits August 2, 2024 17:02
@bdice @wence-
Use :py:attr:
d14d101 
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
@jakirkham
Merge branch 'branch-24.10' into doc-fix-cpu-xref
e25902f
@bdice
Copy link
Contributor Author

bdice commented Aug 5, 2024

This works now in the docs. I'll merge.

@bdice
Copy link
Contributor Author

bdice commented Aug 5, 2024

/merge

@bdice bdice self-assigned this Aug 5, 2024
@rapids-bot rapids-bot bot merged commit 816713e into rapidsai:branch-24.10 Aug 5, 2024
57 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- left review comments

@harrism harrism harrism approved these changes

@leofang leofang Awaiting requested review from leofang

Assignees

@bdice bdice

Labels
doc Documentation non-breaking Non-breaking change Python Related to RMM Python API
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix prefetch docs CPU cross reference
5 participants
@bdice @leofang @jakirkham @harrism @wence-