Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding telemetry #1692

Merged
merged 8 commits into from
Nov 14, 2024
Merged

adding telemetry #1692

merged 8 commits into from
Nov 14, 2024

Conversation

msarahan
Copy link
Contributor

@msarahan msarahan commented Oct 3, 2024

Description

close #1691

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@msarahan msarahan added feature request New feature or request 2 - In Progress Currently a work in progress non-breaking Non-breaking change 5 - DO NOT MERGE Hold off on merging; see PR for details Needs build-infra Requires input from the build infrastructure team labels Oct 3, 2024
@github-actions github-actions bot added the ci label Oct 3, 2024
@msarahan msarahan closed this Oct 3, 2024
@msarahan msarahan reopened this Oct 3, 2024
@msarahan msarahan closed this Oct 3, 2024
@msarahan msarahan reopened this Oct 3, 2024
@msarahan msarahan closed this Oct 3, 2024
@msarahan msarahan reopened this Oct 3, 2024
@msarahan msarahan closed this Oct 4, 2024
@msarahan msarahan reopened this Oct 4, 2024
@msarahan msarahan closed this Oct 4, 2024
@msarahan msarahan reopened this Oct 4, 2024
@msarahan msarahan closed this Oct 10, 2024
@msarahan msarahan reopened this Oct 10, 2024
@msarahan msarahan closed this Oct 10, 2024
@msarahan msarahan reopened this Oct 10, 2024
@msarahan msarahan force-pushed the add-telemetry branch 6 times, most recently from 8410ebb to 8d5473a Compare October 18, 2024 20:12
@github-actions github-actions bot removed the ci label Nov 4, 2024
@msarahan msarahan removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 4, 2024
@msarahan msarahan marked this pull request as ready for review November 4, 2024 16:45
@msarahan msarahan requested a review from a team as a code owner November 4, 2024 16:45
@msarahan msarahan requested a review from bdice November 4, 2024 16:45
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can we do to make this less verbose?

.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
@msarahan msarahan changed the title adding telemetry (testing) adding telemetry Nov 4, 2024
@msarahan msarahan mentioned this pull request Nov 14, 2024
3 tasks
@msarahan msarahan requested a review from bdice November 14, 2024 00:34

telemetry-summarize:
runs-on: ubuntu-latest
needs: pr-builder
Copy link
Contributor

@bdice bdice Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-builder has always been the last job until now. PRs can be merged once pr-builder completes. Is it important for this to complete before merges occur?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was easy to piggy-back on pr-builder being the last thing so that everything else is done. It is not important for this to be complete before merges occur, but it is important that it start only after all other jobs (except pr-builder) are complete. Is there a better way to express that? Making it need conda-python-tests and wheel-python-tests would probably be good enough, and then this would run in parallel with pr-builder. I find that conceptually more messy, but I'm fine with it from a practical standpoint.

If the concern is that the merge would mess up the telemetry, I think that's also going to be OK. The telemetry is all based on github actions run metadata, and I believe that continues to exist until it ages out after some amount of time. The few seconds between a merge event and the summarize action won't matter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I am fine with this depending on pr-builder.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for moving code, otherwise LGTM.

.github/workflows/pr.yaml Outdated Show resolved Hide resolved
@msarahan
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c7fc017 into rapidsai:branch-24.12 Nov 14, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress feature request New feature or request Needs build-infra Requires input from the build infrastructure team non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA] Enable telemetry during RMM's build process
3 participants