-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rmm tests to use rapids_cmake_support_conda_env #1707
Update rmm tests to use rapids_cmake_support_conda_env #1707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we handle installation of tests (e.g. to build the librmm-tests conda packages)? I'm actually a bit confused now because I don't see that package being uploaded anywhere, but I'm asking because I know that for cudf we needed to set up install rules for the conda_env target to make install rules for cudf work transitively, and I'm wondering if we need something similar for tests. It seems like we don't in cudf either, though, so I'm approving under the assumption that I'm missing something about how we handle test installation right now.
All of the RAPIDS |
Where is that logic? I see that we're skipping |
@vyasr That's actually a great question. I had to dig for the answer. Here it is: https://github.com/rapidsai/gha-tools/blob/88a3c66684b02e727fc64246437f2800d9d4ad1e/tools/rapids-find-anaconda-uploads.py#L32-L37 |
Wow that is very hidden... nice find though, thanks! |
/merge |
Description
Fixes issue brought up in rapidsai/rapids-cmake#634 (comment) where rmm wasn't using rapids_cmake_support_conda_env
Checklist