Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rmm tests to use rapids_cmake_support_conda_env #1707

Conversation

robertmaynard
Copy link
Contributor

Description

Fixes issue brought up in rapidsai/rapids-cmake#634 (comment) where rmm wasn't using rapids_cmake_support_conda_env

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Non-breaking change labels Oct 17, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner October 17, 2024 19:10
@github-actions github-actions bot added CMake cpp Pertains to C++ code labels Oct 17, 2024
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we handle installation of tests (e.g. to build the librmm-tests conda packages)? I'm actually a bit confused now because I don't see that package being uploaded anywhere, but I'm asking because I know that for cudf we needed to set up install rules for the conda_env target to make install rules for cudf work transitively, and I'm wondering if we need something similar for tests. It seems like we don't in cudf either, though, so I'm approving under the assumption that I'm missing something about how we handle test installation right now.

tests/CMakeLists.txt Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Oct 18, 2024

How do we handle installation of tests (e.g. to build the librmm-tests conda packages)? I'm actually a bit confused now because I don't see that package being uploaded anywhere

All of the RAPIDS *-test packages are solely used as CI artifacts. We do not publish the *-tests packages to rapidsai-nightly or rapidsai, only the intermediate storage buckets in downloads.rapids.ai used for PR and nightly builds/tests.

@vyasr
Copy link
Contributor

vyasr commented Oct 18, 2024

Where is that logic? I see that we're skipping libcudf-examples in cudf, for example, but not tests, and no equivalent key is specified for rmm.

@bdice
Copy link
Contributor

bdice commented Oct 18, 2024

@vyasr
Copy link
Contributor

vyasr commented Oct 21, 2024

Wow that is very hidden... nice find though, thanks!

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1024a12 into rapidsai:branch-24.12 Oct 22, 2024
58 checks passed
@robertmaynard robertmaynard deleted the fea/update_tests_to_use_rapids_cmake_support_conda_env branch October 22, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp Pertains to C++ code feature request New feature or request non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants