Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: put a ceiling on cuda-python #1723

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Nov 7, 2024

Description

Follow-up to #1720

Contributes to rapidsai/build-planning#116

That PR used != requirements to skip a particular version of cuda-python that rmm was incompatible with. A newer version of cuda-python (12.6.2 for CUDA 12, 11.8.5 for CUDA 11) was just released, and it also causes some build issues for RAPIDS libraries: rapidsai/cuvs#445 (comment)

To unblock CI across RAPIDS, this proposes temporarily switching to ceilings on rmm's cuda-python dependency.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added Python Related to RMM Python API conda labels Nov 7, 2024
@jameslamb jameslamb added bug Something isn't working non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed bug Something isn't working labels Nov 7, 2024
@jameslamb jameslamb changed the title put a ceiling on cuda-python WIP: put a ceiling on cuda-python Nov 7, 2024
@vyasr
Copy link
Contributor

vyasr commented Nov 7, 2024

/merge

@vyasr vyasr marked this pull request as ready for review November 7, 2024 03:19
@vyasr vyasr requested a review from a team as a code owner November 7, 2024 03:19
@vyasr vyasr requested a review from raydouglass November 7, 2024 03:19
@rapids-bot rapids-bot bot merged commit a98c22a into rapidsai:branch-24.12 Nov 7, 2024
58 checks passed
@jameslamb jameslamb deleted the pin-cuda-python branch November 7, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants