Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old rmm::exec_policy #761

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Deprecate old rmm::exec_policy #761

merged 1 commit into from
Apr 22, 2021

Conversation

harrism
Copy link
Member

@harrism harrism commented Apr 22, 2021

There are two versions of rmm::exec_policy. This PR deprecates the old one in thrust_rmm_allocator.h in favor of the new one in exec_policy.hpp.

@harrism harrism requested a review from a team as a code owner April 22, 2021 01:20
@harrism harrism requested review from rongou and codereport April 22, 2021 01:20
@github-actions github-actions bot added the cpp Pertains to C++ code label Apr 22, 2021
@harrism harrism added breaking Breaking change improvement Improvement / enhancement to an existing function labels Apr 22, 2021
@harrism harrism self-assigned this Apr 22, 2021
This was referenced Apr 22, 2021
Merged
Merged
@harrism
Copy link
Member Author

harrism commented Apr 22, 2021

@gpucibot merge

@harrism
Copy link
Member Author

harrism commented Apr 22, 2021

Thanks for the ultra-quick reviews!

@rapids-bot rapids-bot bot merged commit 8d99933 into rapidsai:branch-0.20 Apr 22, 2021
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Apr 22, 2021
@harrism
Remove references to deprecated "rmm/thrust_rmm_allocator.h" (#8027)
f18af7f 
See rapidsai/rmm#761

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu)

URL: #8027
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Apr 30, 2021
@harrism
Remove references to deprecated "rmm/thrust_rmm_allocator.h" (#388)
f00db98 
See rapidsai/rmm#761

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Christopher Harris (https://github.com/cwharris)
  - Paul Taylor (https://github.com/trxcllnt)

URL: #388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@rongou rongou rongou approved these changes

@codereport codereport Awaiting requested review from codereport

Assignees

@harrism harrism

Labels
breaking Breaking change cpp Pertains to C++ code improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harrism @rongou @jrhemstad