-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it easier to include rmm in other projects #788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongou
added
3 - Ready for review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
May 26, 2021
👍 |
Can we retarget this to 21.08? We're at the very end of burndown for 21.06 where I'm not comfortable trying to squeeze this into 21.06. |
robertmaynard
requested changes
May 26, 2021
robertmaynard
approved these changes
May 26, 2021
@kkraus14 looks like CI for 21.08 hasn't been set up yet?
|
kkraus14
approved these changes
May 26, 2021
It has not, ops is working on getting it going now. |
rerun tests |
rerun tests |
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for review
Ready for review by team
CMake
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if we want to include RMM in other cmake projects using CPM, we'd have to do something like this:
With this change, it can be done using the short form:
CPMAddPackage("gh:rapidsai/rmm#0cc1380523d31b2f044ecc74b457b228f8aea0c8")
This is also the recommendation from
Modern CMake
(https://cliutils.gitlab.io/modern-cmake/chapters/testing.html).