Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it easier to include rmm in other projects #788

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented May 26, 2021

Right now if we want to include RMM in other cmake projects using CPM, we'd have to do something like this:

CPMAddPackage(
    NAME rmm
    GIT_REPOSITORY https://github.com/rapidsai/rmm
    GIT_TAG 0cc1380523d31b2f044ecc74b457b228f8aea0c8
    OPTIONS "BUILD_TESTS OFF" "BUILD_BENCHMARKS OFF"
)

With this change, it can be done using the short form:

CPMAddPackage("gh:rapidsai/rmm#0cc1380523d31b2f044ecc74b457b228f8aea0c8")

This is also the recommendation from Modern CMake (https://cliutils.gitlab.io/modern-cmake/chapters/testing.html).

@rongou rongou requested a review from a team as a code owner May 26, 2021 07:27
@github-actions github-actions bot added the CMake label May 26, 2021
@rongou rongou added 3 - Ready for review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 26, 2021
@germasch
Copy link
Contributor

👍

@kkraus14
Copy link
Contributor

Can we retarget this to 21.08? We're at the very end of burndown for 21.06 where I'm not comfortable trying to squeeze this into 21.06.

CMakeLists.txt Outdated Show resolved Hide resolved
@rongou rongou requested a review from a team as a code owner May 26, 2021 15:41
@rongou rongou changed the base branch from branch-21.06 to branch-21.08 May 26, 2021 15:41
@rongou rongou requested a review from robertmaynard May 26, 2021 15:42
@rongou
Copy link
Contributor Author

rongou commented May 26, 2021

@kkraus14 looks like CI for 21.08 hasn't been set up yet?

09:10:24 PackagesNotFoundError: The following packages are not available from current channels:
09:10:24 

09:10:24   - rapids-build-env=21.08

@kkraus14
Copy link
Contributor

@kkraus14 looks like CI for 21.08 hasn't been set up yet?

09:10:24 PackagesNotFoundError: The following packages are not available from current channels:
09:10:24 

09:10:24   - rapids-build-env=21.08

It has not, ops is working on getting it going now.

@rongou
Copy link
Contributor Author

rongou commented May 27, 2021

rerun tests

@rongou
Copy link
Contributor Author

rongou commented Jun 1, 2021

rerun tests

@rongou
Copy link
Contributor Author

rongou commented Jun 1, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 783ed6d into rapidsai:branch-21.08 Jun 1, 2021
@rongou rongou deleted the cpm-add branch October 8, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants