Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build instruction in README #797

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Update build instruction in README #797

merged 3 commits into from
Jul 21, 2021

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jun 7, 2021 •
edited
Loading

  1. Refer to correct env file.
  2. Use conda activate instead of source activate.
  3. Use rmm_dev for the environment name, not cudf_dev.

harrism
harrism requested changes Jun 8, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@harrism harrism added doc Documentation non-breaking Non-breaking change labels Jun 8, 2021
@harrism
Copy link
Member

harrism commented Jul 20, 2021

@hcho3 Any plans to finish this?

@hcho3
Copy link
Contributor Author

hcho3 commented Jul 20, 2021

@harrism Sorry I totally forgot about this PR. I addressed your comment, by removing the link to cuDF's build doc.

@harrism
Copy link
Member

harrism commented Jul 20, 2021

Hmm, style failure seems unrelated to this PR:

ERROR: /workspace/python/rmm/_lib/cuda_stream_pool.pxd Imports are incorrectly sorted and/or formatted.

@harrism
Copy link
Member

harrism commented Jul 21, 2021

rerun tests

@harrism
Copy link
Member

harrism commented Jul 21, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 82fe22f into rapidsai:branch-21.08 Jul 21, 2021
@hcho3 hcho3 deleted the update_readme branch July 21, 2021 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @harrism