Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_cython.py #855

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Fix test_cython.py #855

merged 2 commits into from
Aug 26, 2021

Conversation

ajschmidt8
Copy link
Member

This PR fixes the test_cython.py file so that the cython tests are picked up when running pytest.

cc: @shwina @trxcllnt

@ajschmidt8 ajschmidt8 added bug Something isn't working non-breaking Non-breaking change labels Aug 26, 2021
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner August 26, 2021 15:58
@github-actions github-actions bot added the Python Related to RMM Python API label Aug 26, 2021
This PR fixes the `test_cython.py` file so that the cython tests are picked up when running `pytest`.

cc: @shwina @trxcllnt
@shwina
Copy link
Contributor

shwina commented Aug 26, 2021

I realize this is a PR against 21.08 -- but can we not simply revert to the original test_cython.py?

Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajschmidt8 ajschmidt8 merged commit ccd9647 into rapidsai:branch-21.08 Aug 26, 2021
@ajschmidt8 ajschmidt8 deleted the fix-pytest branch August 26, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants