-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update recipes for Enhanced Compatibility #910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variables specified in conda_build_config.yaml
(like cudaMallocAsync
) can be used as environment variables, which may simplify things here
Thanks @jakirkham! Testing your suggestions locally real quick and then I will commit them. |
Requires more changes. Switching to |
rerun tests |
This reverts commit e9aefba.
@@ -14,7 +14,7 @@ source: | |||
|
|||
build: | |||
number: {{ GIT_DESCRIBE_NUMBER }} | |||
string: cuda_{{ cuda_major }}_py{{ py_version }}_{{ GIT_DESCRIBE_HASH }}_{{ GIT_DESCRIBE_NUMBER }} | |||
string: cuda{{ cuda_major }}_py{{ py_version }}_{{ GIT_DESCRIBE_HASH }}_{{ GIT_DESCRIBE_NUMBER }}_{{ cudaMallocAsync }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the cudaMallocAsync
bit still needed here given the changes above and the fact it is implicit based on CUDA version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have some logic below that depends on this extra metadata in the build string. If you know a way we can work around that, then we could remove the extra {{ cudaMallocAsync }}
bit here.
Lines 116 to 123 in 76ae622
CONDA_FILE=`find $WORKSPACE/ci/artifacts/rmm/cpu/conda-bld/ -name "librmm*no_cma*.tar.bz2"` | |
if [[ "$CUDA_MAJOR_VER" -ge 11 ]] && [[ "$CUDA_MINOR_VER" -ge 2 ]]; then | |
CONDA_FILE=`find $WORKSPACE/ci/artifacts/rmm/cpu/conda-bld/ -name "librmm*has_cma*.tar.bz2"` | |
fi | |
CONDA_FILE=`basename "$CONDA_FILE" .tar.bz2` #get filename without extension | |
CONDA_FILE=${CONDA_FILE//-/=} #convert to conda install | |
gpuci_logger "Installing $CONDA_FILE" | |
gpuci_mamba_retry install -c $WORKSPACE/ci/artifacts/rmm/cpu/conda-bld/ "$CONDA_FILE" |
@gpucibot merge |
This PR tweaks the changes from #893 and #909 so that
rmm
produces two packages (has_cma
andno_cma
) instead oflibrmm
.