-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cuda allocation alignment as default #917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #883 is complete, there will be nothing special about CUDA_ALLOCATION_ALIGNMENT
vs any other specified alignment value that warrants defaulting it like this.
Hmm, but in #883 we are still calling (e.g. in allocation_size =
rmm::detail::align_up(allocation_size, rmm::detail::CUDA_ALLOCATION_ALIGNMENT) Don't we still need to do this type of alignments? |
The new interface allows the user to specify the desired alignment. The default will be |
Wouldn't it still make sense to do this simple cleanup while we wait for the new interface? |
This PR has been labeled |
Possibly, given that #883 and |
Moving to 22.04 |
rerun tests |
@harrism should this be merged? |
@jrhemstad needs to approve. |
rerun tests |
This PR has been labeled |
This is a strict refactoring to make the calling code a bit simpler.