Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable warnings for unknown pragmas #942

Conversation

harrism
Copy link
Member

@harrism harrism commented Jan 12, 2022

CUB 1.15 has uses an unprotected #pragma nv_exec_check_disable which makes includes of thrust headers from .cpp files fail if -Werror is enabled (or warn if it is not set)

This PR is a temporary workaround. It just adds -Wno-unknown-pragmas to the command line for building benchmark .cpp files.

@harrism harrism requested a review from a team as a code owner January 12, 2022 05:26
@github-actions github-actions bot added the CMake label Jan 12, 2022
@harrism harrism added bug Something isn't working non-breaking Non-breaking change labels Jan 12, 2022
@harrism harrism self-assigned this Jan 12, 2022
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes my local builds. It will be good to get #941 as well -- thanks @harrism for the quick fix!

@harrism
Copy link
Member Author

harrism commented Jan 12, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5584a0c into rapidsai:branch-22.02 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants