Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload wheels to public anaconda index #154

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Upload wheels to public anaconda index #154

merged 3 commits into from
Nov 15, 2023

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Nov 13, 2023 •
edited
Loading

PR updates the wheels-publish step to upload wheels to anaconda instead of the existing internal PyPI.

Cross-references:

@AyodeAwe AyodeAwe added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 13, 2023
This was referenced Nov 13, 2023
Merged
Merged
vyasr
vyasr reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we have to propagate the token to all repos that upload wheels? Have we done that yet?

@AyodeAwe AyodeAwe marked this pull request as ready for review November 13, 2023 23:04
@vyasr
Copy link
Contributor

vyasr commented Nov 13, 2023

While we're at it, we should also update https://github.com/rapidsai/shared-workflows/blob/branch-23.12/.github/workflows/build-in-devcontainer.yaml#L96 so that devcontainer builds look in the new index.

@AyodeAwe
Copy link
Contributor Author

Will we have to propagate the token to all repos that upload wheels? Have we done that yet?

Good catch. Looking into that now

@AyodeAwe
Copy link
Contributor Author

Will we have to propagate the token to all repos that upload wheels? Have we done that yet?

Yep. They are propagated to all repos that upload wheels.

@AyodeAwe AyodeAwe merged commit d9cf6f0 into rapidsai:branch-23.12 Nov 15, 2023
@jameslamb jameslamb mentioned this pull request Dec 14, 2023
Merged
@jameslamb jameslamb mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr left review comments

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyodeAwe @vyasr