Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always mark Python 3.11 jobs as successful #182

Merged
merged 2 commits into from
Feb 28, 2024
Merged

always mark Python 3.11 jobs as successful #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e3fe4f
always mark Python 3.11 jobs as successful
jameslamb Feb 28, 2024
4fa0446
one more removal
jameslamb Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/conda-python-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ jobs:
fail-fast: false
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
runs-on: "linux-${{ matrix.ARCH }}-${{ inputs.node_type }}"
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
env:
RAPIDS_ARTIFACTS_DIR: ${{ github.workspace }}/artifacts
container:
Expand Down Expand Up @@ -114,9 +112,18 @@ jobs:
echo "RAPIDS_REF_NAME=${{ inputs.branch || github.ref_name }}" >> "${GITHUB_ENV}"
echo "RAPIDS_NIGHTLY_DATE=${{ inputs.date }}" >> "${GITHUB_ENV}"
- name: Python build
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
run: ${{ inputs.build_script }}
env:
GH_TOKEN: ${{ github.token }}
- name: Upload additional artifacts
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
if: "!cancelled()"
run: rapids-upload-artifacts-dir cuda${RAPIDS_CUDA_VERSION%%.*}_$(arch)_py${RAPIDS_PY_VERSION//.}
# TODO: remove before closing https://github.com/rapidsai/build-planning/issues/3
- name: mark Python 3.11 jobs successful
if: ${{ matrix.PY_VER == '3.11' }}
run: |
exit 0
16 changes: 14 additions & 2 deletions .github/workflows/conda-python-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ jobs:
fail-fast: false
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
runs-on: "linux-${{ matrix.ARCH }}-gpu-${{ matrix.GPU }}-${{ matrix.DRIVER }}-1"
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
env:
RAPIDS_COVERAGE_DIR: ${{ github.workspace }}/coverage-results
RAPIDS_TESTS_DIR: ${{ github.workspace }}/test-results
Expand Down Expand Up @@ -139,20 +137,34 @@ jobs:
echo "RAPIDS_NIGHTLY_DATE=${{ inputs.date }}" >> "${GITHUB_ENV}"
- name: Python tests
run: ${{ inputs.test_script }}
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
env:
GH_TOKEN: ${{ github.token }}
- name: Generate test report
uses: test-summary/action@v2.2
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
with:
paths: "${{ env.RAPIDS_TESTS_DIR }}/*.xml"
if: always()
- name: Run codecov
if: inputs.run_codecov && runner.arch == 'X64'
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
run: |
codecov \
-s \
"${RAPIDS_COVERAGE_DIR}" \
-v
- name: Upload additional artifacts
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
if: "!cancelled()"
run: rapids-upload-artifacts-dir cuda${RAPIDS_CUDA_VERSION%%.*}_$(arch)_py${RAPIDS_PY_VERSION//.}

# TODO: remove before closing https://github.com/rapidsai/build-planning/issues/3
- name: mark Python 3.11 jobs successful
if: ${{ matrix.PY_VER == '3.11' }}
run: |
exit 0
11 changes: 9 additions & 2 deletions .github/workflows/wheels-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ jobs:
strategy:
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
runs-on: "linux-${{ matrix.ARCH }}-${{ inputs.node_type }}"
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
env:
RAPIDS_ARTIFACTS_DIR: ${{ github.workspace }}/artifacts
container:
Expand Down Expand Up @@ -185,12 +183,21 @@ jobs:
persist-credentials: false

- name: Build and repair the wheel
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
run: |
${{ inputs.script }}
env:
GH_TOKEN: ${{ github.token }}
# Use a shell that loads the rc file so that we get the compiler settings
shell: bash -leo pipefail {0}
- name: Upload additional artifacts
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
if: "!cancelled()"
run: rapids-upload-artifacts-dir cuda${RAPIDS_CUDA_VERSION%%.*}_$(arch)_py${RAPIDS_PY_VERSION//.}
# TODO: remove before closing https://github.com/rapidsai/build-planning/issues/3
- name: mark Python 3.11 jobs successful
if: ${{ matrix.PY_VER == '3.11' }}
run: |
exit 0
14 changes: 12 additions & 2 deletions .github/workflows/wheels-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ jobs:
strategy:
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
runs-on: "linux-${{ matrix.ARCH }}-gpu-${{ matrix.gpu }}-${{ matrix.driver }}-1"
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
container:
image: "rapidsai/citestwheel:cuda${{ matrix.CUDA_VER }}-${{ matrix.LINUX_VER }}-py${{ matrix.PY_VER }}"
options: ${{ inputs.container-options }}
Expand Down Expand Up @@ -149,17 +147,29 @@ jobs:
sha: ${{ inputs.sha }}

- name: Run tests
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
run: ${{ inputs.script }}
env:
GH_TOKEN: ${{ github.token }}

- name: Generate test report
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
uses: test-summary/action@v2.2
with:
paths: "${{ env.RAPIDS_TESTS_DIR }}/*.xml"
show: ${{ inputs.test_summary_show }}
if: always()

- name: Upload additional artifacts
# TODO: remove 'continue-on-error' before closing https://github.com/rapidsai/build-planning/issues/3
continue-on-error: ${{ matrix.PY_VER == '3.11' }}
if: "!cancelled()"
run: rapids-upload-artifacts-dir cuda${RAPIDS_CUDA_VERSION%%.*}_$(arch)_py${RAPIDS_PY_VERSION//.}

# TODO: remove before closing https://github.com/rapidsai/build-planning/issues/3
- name: mark Python 3.11 jobs successful
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure if this step is necessary, but it doesn't hurt. We have enough testing to know that this PR will help unblock CI.

if: ${{ matrix.PY_VER == '3.11' }}
run: |
exit 0