Check job results in pr-builder #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ac81e3f.
3 tasks
bdice
reviewed
Aug 22, 2024
bdice
approved these changes
Aug 22, 2024
bdice
reviewed
Aug 22, 2024
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/gha-tools
that referenced
this pull request
Aug 23, 2024
With rapidsai/shared-workflows#237, workflows may now specify `if: always()` to allow skipping jobs. This requires passing a `needs` input with `${{ toJSON(needs) }}`. Enforce this new rule in `rapids-check-pr-job-dependencies`, and add some tests for the tool.
This was referenced Aug 23, 2024
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Aug 23, 2024
…celled" (#1860) CIs are failing because of #1736 not playing well with rapidsai/shared-workflows#237 As a stopgap I am reverting the changes in #1736 Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #1860
dagardner-nv
pushed a commit
to dagardner-nv/Morpheus
that referenced
this pull request
Aug 23, 2024
…celled" (nv-morpheus#1860) CIs are failing because of nv-morpheus#1736 not playing well with rapidsai/shared-workflows#237 As a stopgap I am reverting the changes in nv-morpheus#1736 Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: nv-morpheus#1860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new input,
needs, which should just be the value of${{ toJSON(needs) }}from the calling workflow. This input will be checked to see if all of the needed jobs have a result of eithersuccessorskipped. This allows dependencies ofpr-builderto be skipped. See rapidsai/cudf#16642 (comment) for the motivating use case.Workflows that use
pr-buildershould haveif: always()andwith: needs: ${{ toJSON(needs) }}. Workflows that have not yet been updated for this new input will continue to work as before, because theneedsinput has a default value of{}, which will always pass this check, just as if the oldexit 0had been called.