Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version error message #1069

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

pentschev
Copy link
Member

Update version error message to match the minimum support UCX version and provide instructions to check where UCX is being loaded from.

Closes #1068 .

Update version error message to match the minimum support UCX version
and provide instructions to check where UCX is being loaded from.
@pentschev
Copy link
Member Author

@madsbk would you mind having a look/approving here as well? This is the same change as you reviewed in rapidsai/ucxx#277 with your suggestion also applied here now via 11c637d .

Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @pentschev

rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this pull request Sep 16, 2024
Update version error message to match the minimum support UCX version and provide instructions to check where UCX is being loaded from.

Ported from rapidsai/ucx-py#1069

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Mads R. B. Kristensen (https://github.com/madsbk)

URL: #277
@pentschev
Copy link
Member Author

Thanks @madsbk !

@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 229b6a0 into rapidsai:branch-0.40 Sep 16, 2024
39 checks passed
@pentschev pentschev deleted the version-error branch November 15, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError raises 1.11 while check is for 1.15
2 participants