Skip to content

Commit

Permalink
Remove invalid install locations (#157)
Browse files Browse the repository at this point in the history
UCXX has no generated headers in the build directory, so these incorrect includes result in a build directory that is not directly usable as a dependency.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #157
  • Loading branch information
vyasr authored Jan 10, 2024
1 parent 9ef2d0c commit c2f25c8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ set_property(
)
message(VERBOSE "UCXX: RMM_LOGGING_LEVEL = '${RMM_LOGGING_LEVEL}'.")

if(NOT UCXX_GENERATED_INCLUDE_DIR)
set(UCXX_GENERATED_INCLUDE_DIR ${UCXX_BINARY_DIR})
endif()

# ##################################################################################################
# * conda environment -----------------------------------------------------------------------------
rapids_cmake_support_conda_env(conda_env MODIFY_PREFIX_PATH)
Expand Down Expand Up @@ -151,7 +147,6 @@ target_compile_options(
target_include_directories(
ucxx
PUBLIC "$<BUILD_INTERFACE:${UCXX_SOURCE_DIR}/include>"
"$<BUILD_INTERFACE:${UCXX_GENERATED_INCLUDE_DIR}/include>"
PRIVATE "$<BUILD_INTERFACE:${UCXX_SOURCE_DIR}/src>"
INTERFACE "$<INSTALL_INTERFACE:include>"
)
Expand Down
2 changes: 0 additions & 2 deletions cpp/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ target_include_directories(
ucxx_python
PUBLIC "$<BUILD_INTERFACE:${UCXX_SOURCE_DIR}/include>"
"$<BUILD_INTERFACE:${UCXX_SOURCE_DIR}/python/include>"
"$<BUILD_INTERFACE:${UCXX_GENERATED_INCLUDE_DIR}/include>"
"$<BUILD_INTERFACE:${UCXX_GENERATED_INCLUDE_DIR}/python/include>"
PRIVATE "$<BUILD_INTERFACE:${UCXX_SOURCE_DIR}/src>"
INTERFACE "$<INSTALL_INTERFACE:include>"
)
Expand Down

0 comments on commit c2f25c8

Please sign in to comment.