-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target branch-24.04 for GitHub Actions workflows #191
Conversation
Thanks James! 🙏 There was a network error in one job that caused the rest to cancel at that point. Restarted CI |
Seeing flaky test failures. Restarting Edit: Restarting again x2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm just wondering if this is ready to merge or if there are other requirements, I noticed some tests have started failing due to the lack of this change:
ValueError: No matching matrix found in 'cuda_version' for: {'cuda': '12.2', 'arch': 'x86_64', 'py': '3.10'}
This is ready to merge. It should be a no-op from the perspective of this project... the But @pentschev I see the error you're referring to, on #192 for example (build link)
Can you please update that branch to the latest |
@jameslamb you're right, merging |
No problem! I've noticed that other RAPIDS repos have "always suggest updating pull request branches" checked in their settings: Which causes a button to show up down in the checks & merge section showing that the branch isn't up to date with the target, like this: I don't believe I saw that earlier when I looked at #192, so I suspect this repo doesn't have that enabled. I recommend enabling that setting, I've found it super useful! |
I think it only does that after a certain number of PRs, at least that's what my past experience with that feature seemed like with various repos, i.e., if it's only behind for one or two commits that warning may not show up. |
I've enabled it |
I'm seeing the following errors in repos where UCXX is required (namely Dask-CUDA and RAFT PR where UCXX support is being added):
I'm assuming this PR will resolve that, is that right @jameslamb ? Is there anything else that needs to be done here or are we good to merge it? |
This is good to merge any time, but @pentschev it won't affect that issue you've linked to. This PR just updates which branch of https://github.com/rapidsai/shared-workflows GitHub Actions configuration is pulled from, and the current branch ( |
Thanks @jameslamb , following up on that discussion offline. |
/merge |
thanks! |
Description
Follow-up to #161
For all GitHub Actions configs, replaces uses of the
test-cuda-12.2
branch onshared-workflows
with
branch-24.04
, now that rapidsai/shared-workflows#166 has been merged.Notes for Reviewers
This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.
For more details see:
(created with
rapids-reviser
)