Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum UCX runtime pin #240

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Conversation

pentschev
Copy link
Member

Increase maximum UCX runtime pin to support UCX up to v1.17.x, but still build against v1.15.0 until we gain confidence with newer UCX.

Additionally disable protov2 by default as CUDA async/managed memory is not yet supported and leads to poor performance.

@pentschev pentschev requested review from a team as code owners June 28, 2024 11:53
@pentschev pentschev requested a review from jameslamb June 28, 2024 11:53
@pentschev pentschev added feature request New feature or request non-breaking Introduces a non-breaking change labels Jun 28, 2024
@msarahan
Copy link
Contributor

Seems like the (private) cudf testing API may have changed:

FAILED python/ucxx/_lib_async/tests/test_custom_send_recv.py::test_send_recv_cudf[<lambda>0] - ImportError: cannot import name 'assert_eq' from 'cudf.testing._utils' (/opt/conda/envs/test/lib/python3.11/site-packages/cudf/testing/_utils.py)

@pentschev
Copy link
Member Author

Seems like the (private) cudf testing API may have changed:

FAILED python/ucxx/_lib_async/tests/test_custom_send_recv.py::test_send_recv_cudf[<lambda>0] - ImportError: cannot import name 'assert_eq' from 'cudf.testing._utils' (/opt/conda/envs/test/lib/python3.11/site-packages/cudf/testing/_utils.py)

This was fixed in #239 but I had an out-of-date branch. Merged upstream now and it should be fixed.

python/ucxx/__init__.py Outdated Show resolved Hide resolved
@pentschev pentschev changed the base branch from branch-0.39 to branch-0.40 July 30, 2024 15:50
@pentschev
Copy link
Member Author

Thanks everyone for reviews/approvals here.

@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit c0acb1e into rapidsai:branch-0.40 Jul 31, 2024
55 checks passed
@pentschev pentschev deleted the ucx-1.17 branch August 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants