Add libucxx wheel #260
Add libucxx wheel #260
Conversation
There was a problem hiding this comment.
These edits might get you on the right track. The argument that is cpp or python is backwards compatible, but if not present, it behaves as just python, and the filenames don't line up.
Edit: for reference, here's where the bash script in action here lives: https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-upload-wheels-to-s3#L11, which eventually leads to the real difference in file naming: https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-package-name#L32
|
Before this change: ucxx_cu12-0.40.0a14-cp311-cp311-manylinux_2_28_x86_64.whl - 5.2MB After this change: libucxx_cu12-0.40.0a32-py3-none-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl - 512KB As you can see, there is a 76% reduction in total wheel size. |
|
/merge |
*.pxd files were mistakenly removed in rapidsai#260. Resume installing them in the ucxx wheel.
`*.pxd` files were mistakenly removed in #260. Resume installing them in the ucxx wheel. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #270
Follow-up to #260. Contributes to rapidsai/build-planning#33 Limits `libucxx` wheel-building to just running once per combination of `(CUDA version, CPU architecture)`... cutting out 8 unnecessary CI jobs per commit. ## Notes for Reviewers ### Why is this safe to do? Unlike wheels that have Cython code, `libucxx` wheels don't depend on the Python minor version https://github.com/rapidsai/ucxx/blob/ec860d901f944625e506d85adc0e08021fa4ffd4/python/libucxx/pyproject.toml#L48 e.g., they have tags like ```text libucxx_cu12-0.42.0a18-py3-none-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl ``` Similar filters are being used for most C++ wheel builds across RAPIDS, e.g. https://github.com/rapidsai/cudf/blob/a95fbc88f94df24c3418766fbbea5b6633ff2328/.github/workflows/pr.yaml#L222-L230 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Mike Sarahan (https://github.com/msarahan) URL: #344
Contributes to rapidsai/build-planning#33