Add a timeout argument to progressWorkerEvent
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of blocking indefinitely until an evens occurs, allows the user to specify a timeout the epoll wait operation, causing it to return. In some cases using blocking mode in the progress thread may cause the event to never wake, allowing it to break periodically fixes hangs in those cases. It's not clear whether this is an abuse of blocking progress mode in UCX, but for now this resolves that issue.
pentschev
added
bug
wence-
reviewed
Apr 26, 2023
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
…ker_event-timeout
…ker_event-timeout
…nto progress_worker_event-timeout
wence-
approved these changes
Apr 27, 2023
|
Thanks @wence- ! |
|
And btw, the Python benchmark timed out several times here, I now opened #37 to increase the timeout for now. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of blocking indefinitely until an evens occurs, allows the user to specify a timeout the epoll wait operation, causing it to return.
In some cases using blocking mode in the progress thread may cause the event to never wake, allowing it to break periodically fixes hangs in those cases. It's not clear whether this is an abuse of blocking progress mode in UCX, but for now this resolves that issue.