Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable various C++ build-time warnings and treat them as errors #340

Merged
merged 11 commits into from
Dec 19, 2024
Merged

Enable various C++ build-time warnings and treat them as errors #340

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c22954e
Enable `-Wall -Wattributes -Werror` in C++ build
pentschev Nov 29, 2024
39c3a9f
Fix build warnings and errors
pentschev Nov 29, 2024
ba26e7e
Extended build-time warnings
pentschev Nov 29, 2024
c1174a5
Fix more build warnings
pentschev Nov 29, 2024
5c0be47
Merge branch 'branch-0.42' into enable-build-warnings-errors
pentschev Nov 29, 2024
7ff4ff2
Merge remote-tracking branch 'upstream/branch-0.42' into enable-build…
pentschev Dec 13, 2024
f974f2c
Remove redundant double quotes
pentschev Dec 13, 2024
a1ce4d5
Merge remote-tracking branch 'origin/enable-build-warnings-errors' in…
pentschev Dec 13, 2024
9a9f96c
Style fixes
pentschev Dec 16, 2024
7b8c0db
Workaround cpplint bug https://github.com/cpplint/cpplint/issues/131
pentschev Dec 16, 2024
9d1e5bf
Merge branch 'branch-0.42' into enable-build-warnings-errors
pentschev Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ set(UCXX_BUILD_TESTS ${BUILD_TESTS})
set(UCXX_BUILD_BENCHMARKS ${BUILD_BENCHMARKS})
set(UCXX_BUILD_EXAMPLES ${BUILD_EXAMPLES})

set(UCXX_CXX_FLAGS "")
set(UCXX_CXX_FLAGS "-Wall" "-Wattributes" "-Werror")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other things that might be worthwhile adding -Wextra, -Wsign-conversion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lawrence for the suggestions. I've extended those in ba26e7e . Additionally I added -Wno-missing-field-initializers this is because we otherwise hit those warnings when initializing many of the UCP structures where we don't (and probably shouldn't, at least not in all cases) fill those values. Alternatively we could use #pragmas to filter them out, but I'm not sure if it's worth it. If you have other better ideas please let me know as well.

set(UCXX_CXX_DEFINITIONS "")

# Set RMM logging level
Expand Down
Loading