Linking failure on big endian (s390x) #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/usr/bin/ld: umac128.o (symbol from plugin): in function `umac_put_u32_le': (.text+0x0): multiple definition of `umac_put_u32_le'; umac.o (symbol from plugin):(.text+0x0): first defined here collect2: error: ld returned 1 exit status This function (umac_put_u32_le) has been enclosed in a #if (! __LITTLE_ENDIAN__) /* compile time warning thrown otherwise */ block in order to fix this issue for little endian architectures. Since the function is not used on big endian architectures either, this can be fixed by changing the above to #if 0 /* compile time warning thrown otherwise */
|
I need to review this entire patch as I am not sure it's actually providing the performance benefit I think it is providing. If it isn't then I need to revert this entire patch. One way or the other this will be resolved in the next release. |
|
This will be available in HPN-SSH 18.6.0. However, we don't use the master branch for development so things that impact functionality have to go into a sub-branch that we then merge in. So while this PR looks like it's getting rejected it absolutely isn't. I just wanted to let you know. |
rapier1
added a commit
that referenced
this pull request
Sep 27, 2024
…an architectures. A one line fix provided by Mattias Ellert. See #93 for the PR.
|
This change has been added to 18.6.0. Thanks for submitting this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/bin/ld: umac128.o (symbol from plugin): in function
umac_put_u32_le': (.text+0x0): multiple definition ofumac_put_u32_le'; umac.o (symbol from plugin):(.text+0x0): first defined herecollect2: error: ld returned 1 exit status
This function (umac_put_u32_le) has been enclosed in a
block in order to fix this issue for little endian architectures. Since the function is not used on big endian architectures either, this can be fixed by changing the above to