Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop ci #3

Merged
merged 3 commits into from
Aug 13, 2017
Merged

Develop ci #3

merged 3 commits into from
Aug 13, 2017

Conversation

rapirent
Copy link
Owner

you can check the .travis.yml for more

@Lee-W
Copy link
Collaborator

Lee-W commented Aug 13, 2017

Is there any reason why only branch names that match "^devlop.*$" are checked?

@Lee-W
Copy link
Collaborator

Lee-W commented Aug 13, 2017

Branch develop-postgis has been rebased on PR#2.
Thus, you'll have to reflect the change to prevent conflict or useless commit.

It seems that your setup depends on the update of requirement/dev.txt.
Since PR#2 has been merged, I suggest that you can create a branch from develop (or commit 5da5) again and use git cherry-pick on your new commits (i.e. commit d8e1^..9cbc).

@Lee-W
Copy link
Collaborator

Lee-W commented Aug 13, 2017

Once you make these changes, I'll add some simple test (e.g. whether we can run the server properly) to ensure that CI works as we expect.
Also, it seems there are some issues on .coveragerc.
I'll fix that as well.

@rapirent
Copy link
Owner Author

I think the stable version which has already passed the test will be merge to branch named 'deploy' or 'master', on which test is useless.
that's why I set only branch named 'develop' will run the test.

@Lee-W
Copy link
Collaborator

Lee-W commented Aug 13, 2017

It sounds reasonable.
I'll survey on the best practice of this issue.
But that will be fine by now.

@Lee-W
Copy link
Collaborator

Lee-W commented Aug 13, 2017

LGTM.

@Lee-W Lee-W merged commit 6ca53aa into develop Aug 13, 2017
@Lee-W Lee-W deleted the develop-CI branch August 15, 2017 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants