Fixes 2fa disabled, but still shows when route is '/admin' #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync up with Rappasoft
When logging in when 2fa is disabled in .env, the redirect could point to "/admin", but the middleware checks for 'admin/*', which fails the test and shows the 2fa requirement page. Going to any other page does not show the 2fa requirement page. This small change catches the '/admin' url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging in when ADMIN_REQUIRES_2FA=false in .env, the successful admin redirect could point to "/admin", but the TwoFactorAuthenticationStatus middleware checks for
$request->is('admin/*')which fails the test and shows the 2fa requirement page. Going to any other admin page does not show the 2fa requirement page. This small change catches the 'admin' url by changing
$request->is('admin/*')to
$request->is('admin*')