Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new filter for <select multiple> (MultiSelectDropdownFilter) #1011

Merged
merged 7 commits into from
Jan 17, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 10, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Adds a new filter type (MultiSelectDropdownFilter) which is a version of the MultiSelectFilter, along with updated tests and documentation

@lrljoe lrljoe changed the title Multi select dropdown filter Adding an option to set the SlideDown filter panel to "Open By Default" and "Closed by Default", Default is "Closed by Default". Jan 12, 2023
@lrljoe lrljoe changed the title Adding an option to set the SlideDown filter panel to "Open By Default" and "Closed by Default", Default is "Closed by Default". Adding a new filter for <select multiple> (MultiSelectDropdownFilter) Jan 12, 2023
lrljoe and others added 3 commits January 13, 2023 06:12
This remove the work-around of creating two arrays and merging them to get the evalues. followed by the reslts Buiilder/Qiery
@lrljoe
Copy link
Collaborator Author

lrljoe commented Jan 13, 2023

Note that this branch has now had additional updates to include a "setFirstOption('value')" to set a default (top of list) option, that when selected also removes the filter from the query.

@rappasoft rappasoft added the Awaiting Next Release Currently merged into development awaiting a release to master label Jan 17, 2023
@rappasoft rappasoft mentioned this pull request Jan 17, 2023
@rappasoft rappasoft merged commit 851201f into rappasoft:master Jan 17, 2023
Multi-select dropdown filters are a simple dropdown list. The user can select multiple options from the list. There is also an 'All' option that will select all values

```php
use Rappasoft\LaravelLivewireTables\Views\Filters\SelectFilter;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "MultiSelect Dropdown Filter"?

@lrljoe lrljoe deleted the MultiSelectDropdownFilter branch April 17, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants