Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New configurable area 'before-tools', to be able to place above also the pills #1037

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

SimonMacIntyre
Copy link
Contributor

@SimonMacIntyre SimonMacIntyre commented Feb 1, 2023

Adds a configurable before-tools section, to be able to be at the very tip-top even above filter/sort pills.

Example video attached.

Screen.Recording.2023-02-01.at.12.57.02.PM.mov

Related to a previous PR attempting the same thing in a different way: #1036

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@SimonMacIntyre
Copy link
Contributor Author

@lrljoe Hello again 🙏 , I tried another adaption per your advice, what do you think of this change?

@SimonMacIntyre SimonMacIntyre changed the title Before tools New configurable area 'before-tools', to be able to place above also the pills Feb 1, 2023
@SimonMacIntyre
Copy link
Contributor Author

Regarding the documentation, I'm not sure how to mimic the exact tables already used in the Areas sections example. I fear adding my unique example from a different table/project might look jarring among the other image examples... 🤔

@rappasoft rappasoft changed the base branch from master to develop February 15, 2023 03:16
@rappasoft rappasoft merged commit 5b4d521 into rappasoft:develop Feb 15, 2023
@rappasoft rappasoft mentioned this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants