Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filter pill values for option groups #1044

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

tobiashammarstrand
Copy link
Contributor

Fixed support for options groups for the multi-select dropdown filter.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. [] Does your submission pass tests and did you add any new tests needed for your feature?
  2. [] Did you update all templates (if applicable)?
  3. [] Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe
Copy link
Collaborator

lrljoe commented Feb 12, 2023

Good catch, something I missed in my testing! Cheers

@rappasoft rappasoft changed the base branch from master to develop February 15, 2023 02:58
@rappasoft rappasoft merged commit 5b50740 into rappasoft:develop Feb 15, 2023
@rappasoft rappasoft mentioned this pull request Feb 16, 2023
Copy link
Contributor Author

@tobiashammarstrand tobiashammarstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@lrljoe
Copy link
Collaborator

lrljoe commented Apr 17, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants