Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Tweaks - Removing Separate CS-Fixer #1125

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Mar 29, 2023

Run-Tests now runs in the following order

  • First run PHP CS Fixer
  • Next run the matrix
    This removes the potential for CS Fixer to make changes to the codebase after tests have commenced.

Matrix no longer refers to Laravel versions by "10.", but instead by full version. "." is appended when installing. This simplifies cache creation/usage, and simplifies future version-dependent steps

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Run-Tests now runs in the following order
- First run PHP CS Fixer (on PUSH ONLY)
- Next run the matrix

This removes the potential for CS Fixer to make changes to the codebase after tests have commenced.
@lrljoe lrljoe merged commit 03b4e53 into rappasoft:develop Mar 29, 2023
@rappasoft rappasoft mentioned this pull request Apr 8, 2023
@lrljoe lrljoe deleted the devWFTweaks branch July 15, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant