Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlpineJS - Bulk Actions Fixes #1218

Merged
merged 15 commits into from
May 18, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented May 18, 2023

Several fixes for bugs with AlpineJS Bulk Actions that came up with the 2.13 release.

Full list of fixes below:

  • Fixes

    • Bulk Actions (AlpineJS)
    • Moving the Table Head Checkbox to AlpineJS
    • Using AlpineJS for calculating if all items have been selected or not
    • Correcting missing x-cloak which was causing flicker on render.
    • Added indeterminateCheckbox for TH for bulk actions (all checked, some checked, none checked)
    • Cleaned up AlpineJS functionality for Bulk Actions
    • Repair of tests that were looking for wire:model that no longer existed
  • Enhancements

    • Several new public variables for accessing pagination data cleanly, to avoid calling functions repeatedly across various blades.
      • paginationTotalItemCount (Total number of items in the results across all page)
      • paginationCurrentItems (Primary keys of items in the current page)
      • paginationCurrentCount (Number of results on the current page)
  • Blades

    • Several blades have had the classic Tables approach ($theme == 'tailwind', $theme == 'bootstrap) replaced with conditional classes using the @Class([]) approach. This is to reduce the complexity of the blade files.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe merged commit 5b88b0d into rappasoft:develop May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant