Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dutch translation for "Select All On Page" #1220

Merged
merged 7 commits into from
May 21, 2023
Merged

Add dutch translation for "Select All On Page" #1220

merged 7 commits into from
May 21, 2023

Conversation

siebsie23
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe
Copy link
Collaborator

lrljoe commented May 21, 2023

Thanks for the commit, I'll get this updated shortly.

I'm trying to keep track of localisation contributors, are you happy for me to reference you for Dutch?

That way any future localisation additions we will give you an @ in advance so that you don't end up with non translated phrases in your site!

@lrljoe lrljoe changed the base branch from master to develop May 21, 2023 02:38
@lrljoe lrljoe added Version 2 Version 2 of Package localisation Localisations/Translations labels May 21, 2023
@lrljoe lrljoe merged commit 0f1e8dc into rappasoft:develop May 21, 2023
@siebsie23
Copy link
Contributor Author

Thanks for the commit, I'll get this updated shortly.

I'm trying to keep track of localisation contributors, are you happy for me to reference you for Dutch?

That way any future localisation additions we will give you an @ in advance so that you don't end up with non translated phrases in your site!

That would be great! Happy to help translating :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation Localisations/Translations Version 2 Version 2 of Package
Projects
Status: Merged to Develop
Development

Successfully merging this pull request may close these issues.

4 participants