Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Select All On Page translation #1244

Merged
merged 8 commits into from
Jun 25, 2023

Conversation

sebacastroh
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

About this PR

I noticed that the text "Select All On Page" used in resources/lang/components/table/tr/bulk-actions.blade.php wasn't being translated.

imagen

I added the text in the english and spanish translation files.

imagen

If you want, you can send me other translations and I can add it to the PR.

@lrljoe
Copy link
Collaborator

lrljoe commented Jun 9, 2023

Thanks for the translation, I'll get it merged over the weekend.

Are you happy for me to defer to you for Spanish translations in the future? I'm steadily building a list of translation contributors, particularly as we start to look at v3.

@sebacastroh
Copy link
Contributor Author

Yeah, no problem 😉

@lrljoe lrljoe changed the base branch from master to develop June 23, 2023 18:16
@sebacastroh
Copy link
Contributor Author

Updated README.md based on dev branch

@lrljoe lrljoe merged commit 51c3dd6 into rappasoft:develop Jun 25, 2023
@lrljoe
Copy link
Collaborator

lrljoe commented Jun 25, 2023

Merged into develop. Thanks for the contrib, I'll add you into the list of translation contributors shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants