Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide filters when $showFilters is false #285

Merged
merged 1 commit into from
May 19, 2021

Conversation

bdelamatre
Copy link
Contributor

Pretty much the title.

Scenario is that you have a table with filters (e.g. controlled via query parameters or another form) but you don't want the filters to show. I would expect $showFilters to hide the filters dropdown, but it currently doesn't.

@rappasoft
Copy link
Owner

Hmm, tricky because $showSorting hides the pills but does not disable sorting, not sure if it's completely the same but I want to make sure I don't confuse people.

@bdelamatre
Copy link
Contributor Author

bdelamatre commented May 14, 2021 via email

@rappasoft
Copy link
Owner

Yeah, I think a different property, only because I use the default dropdown, but I do hide the pills with that sometimes as they're mostly fluff. $showFilterDropdown or something.

@rappasoft rappasoft added the Awaiting Next Release Currently merged into development awaiting a release to master label May 19, 2021
@rappasoft rappasoft mentioned this pull request May 19, 2021
@rappasoft rappasoft merged commit 5d4c00f into rappasoft:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants