Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bulk actions function #517

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Fix bulk actions function #517

merged 2 commits into from
Oct 25, 2021

Conversation

fabio-ivona
Copy link
Contributor

@fabio-ivona fabio-ivona commented Oct 19, 2021

@rappasoft , a conflict resolve merge broke the bulkActions() function feature:

7512de5 in WithBulkActions trait restored the default public array $bulkActions = []; property that in my PR #467 got replaced by this:

public function getBulkActionsProperty(): array
{
    return $this->bulkActions();
}

I updated the test I wrote to ensure bulk actions are taken from the getBulkActionsProperty() function and not from the default property (that should not be present in the core code, but only added if needed by the class extending DataTableComponent)

@emildayan
Copy link

When will this be merged in? Broke parts of our app :(

@fabio-ivona
Copy link
Contributor Author

I hope as soon as possible, it broke some of our apps too

@rappasoft hasn't made activities on this project for some days, maybe he has been busy.

This is an open source project, it's not his main business I think, but he will merge it soon

Meanwhile I've switched the composer to the dependency with my fix branch, so apps will keep working. I'll switch back to the standard package as soon as it is merged

@CristhoferMF
Copy link
Contributor

When will this be merged in? Broke parts of our app :(

@rappasoft Please soon

@rappasoft rappasoft added the Awaiting Next Release Currently merged into development awaiting a release to master label Oct 25, 2021
@rappasoft
Copy link
Owner

I'll get it merged today.

@rappasoft rappasoft mentioned this pull request Oct 25, 2021
@fabio-ivona
Copy link
Contributor Author

I'll get it merged today.

thanks! 🙏 😄

@rappasoft
Copy link
Owner

I'll get to the rest of the issues and PR's later tonight.

@rappasoft rappasoft merged commit a2ea427 into rappasoft:master Oct 25, 2021
@fabio-ivona fabio-ivona deleted the fix-bulk-actions-function branch October 25, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants