v2.8.0 #854
Merged
v2.8.0 #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tables into column-select
`LinkColumn::make()->title()` gives currently an error in PHPStan in my project because it expects `LinkColumn::make` to return a `Column` even though it returns a `LinkColumn`. I saw in your composer.json file that you also maintain compatability with 7.4, so I only changed the return type in the doc block. Ideal would of course be to also have `static` as return type also in the code itself.
Column selection should be disabled for multiple of same component. - It has never worked and the only way to make it work now would be to pass in some identifier at mount() and use that to change the fingerprint with `setDataTableFingerprint()`. - Due to the high potential for errors in setting arbitrary properties and manipulating them at mount(), then attempting to use them in configure(), I think it's best not to support this type of configuration in the docs, although IT CAN BE DONE. - There is a suggestion in the docs for reusing components on different pages which is less error prone.
This reverts commit 3a03091.
Column select
Additional commas
Column select
Select deselect all columns
French translation file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed