Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for select and checkbox inputs styling with Bootstrap 5 theme #864

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

WhereIsLucas
Copy link
Contributor

@WhereIsLucas WhereIsLucas commented Aug 3, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Hi,

The arrow on the select input is not visible with the Bootstrap 5 theme.
image
image

This is due to the fact that Bootstrap 5 selects are now using the form-select class instead of form-control.

See below in the docs :
https://getbootstrap.com/docs/5.2/forms/select/
https://getbootstrap.com/docs/5.0/migration/

This PR fixes this.

@WhereIsLucas WhereIsLucas changed the title Fix for select with Bootstrap 5 theme Fix for select inputs styling with Bootstrap 5 theme Aug 8, 2022
@WhereIsLucas
Copy link
Contributor Author

As issue #868 pointed, checkbox inputs were also incorrectly styled for Bootstrap 5. I added the fixes to my current PR for select.

@WhereIsLucas WhereIsLucas changed the title Fix for select inputs styling with Bootstrap 5 theme Fix for select and checkbox inputs styling with Bootstrap 5 theme Aug 9, 2022
@WhereIsLucas
Copy link
Contributor Author

Hi,

Any chance this PR gets merged ?

Thanks !

@stale
Copy link

stale bot commented Sep 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 24, 2022
@stale stale bot closed this Oct 1, 2022
@rappasoft rappasoft reopened this Oct 2, 2022
@stale stale bot removed the wontfix This will not be worked on label Oct 2, 2022
@ccsliinc
Copy link
Contributor

Can this be merged or does it need more work?

@stale
Copy link

stale bot commented Nov 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 17, 2022
@stale stale bot closed this Nov 24, 2022
@rappasoft rappasoft reopened this Nov 25, 2022
@stale stale bot removed the wontfix This will not be worked on label Nov 25, 2022
@rappasoft rappasoft added the Awaiting Next Release Currently merged into development awaiting a release to master label Dec 21, 2022
@rappasoft rappasoft mentioned this pull request Dec 22, 2022
@rappasoft rappasoft merged commit 3e12de8 into rappasoft:master Dec 22, 2022
@WhereIsLucas
Copy link
Contributor Author

Thanks !

@ccsliinc
Copy link
Contributor

I think the bulk actions is not fixed. Let me see if I can just grab the code for that control.

@ccsliinc
Copy link
Contributor

ccsliinc commented Dec 22, 2022

I don't remember what I did, but I changed something in this section toolbar.blade.php:490 or around.

            @if ($component->showBulkActionsDropdown())
                {{-- TODO - dropdown --}}
                <div class="mb-3 mb-md-0">
                    <div class="dropdown d-block d-md-inline">
                        <button class="btn dropdown-toggle d-block w-100 d-md-inline" type="button"
                                id="{{ $component->getTableName() }}-bulkActionsDropdown" data-toggle="dropdown"
                                aria-haspopup="true" aria-expanded="false">
                            @lang('Bulk Actions')
                        </button>

                        <div class="dropdown-menu dropdown-menu-right w-100"
                             aria-labelledby="{{ $component->getTableName() }}-bulkActionsDropdown">
                            @foreach($component->getBulkActions() as $action => $title)
                                <a
                                    href="#"
                                    wire:click="{{ $action }}"
                                    wire:key="bulk-action-{{ $action }}-{{ $component->getTableName() }}"
                                    class="dropdown-item"
                                >
                                    {{ $title }}
                                </a>
                            @endforeach
                        </div>
                    </div>
                </div>
            @endif

@ccsliinc
Copy link
Contributor

This allows for the bulk options to dropdown, it looks good, but does not work.

ccsliinc added a commit to ccsliinc/laravel-livewire-tables that referenced this pull request Dec 22, 2022
This was a change implemented via the coreui update.
lrljoe added a commit to LowerRockLabs/laravel-livewire-tables that referenced this pull request Jan 12, 2023
Reference to rappasoft#864 fixes for bootstrap-5 theme
lrljoe added a commit to LowerRockLabs/laravel-livewire-tables that referenced this pull request Mar 31, 2023
* Reference to rappasoft#864 fixes for bootstrap-5 theme

This was a change implemented via the coreui update.

* Updated toolbar.php to allow dropdown functionality.

Changed the dropdown behavior to Alpine.js to the same behavior as the column select.

* Update toolbar.blade.php

wire:key name was incorrect.

---------

Co-authored-by: ccsliinc <jsugamele@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants