feat(PLTF-215): fixes transactions for backend service

packages/ethereum/sdk/src/order/fill-order/index.ts

@@ -170,11 +170,20 @@ export class OrderFiller {
 	public acceptBid: SellOrderAction = this.getFillAction<SellOrderRequest>()
 
 	async getBuyTx({ request, from }: GetOrderBuyTxRequest): Promise<TransactionData> {
+		if (!this.isNonInvertableOrder(request.order) && !from) {
+			throw new Error("'From' field must be specified for this order type")
+		}
 		const inverted = this.isNonInvertableOrder(request.order) ? request.order : await this.invertOrder(request, from)
 		if (request.assetType && inverted.make.assetType.assetClass === "COLLECTION") {
 			inverted.make.assetType = await this.checkAssetType(request.assetType)
 		}
-		const { functionCall, options } = await this.getTransactionRequestData(request, inverted)
+		const { functionCall, options } = await this.getTransactionRequestData(
+			request,
+			inverted,
+			{
+				disableCheckingBalances: true,
+			}
+		)
 		const callInfo = await functionCall.getCallInfo()
 		const value = options.value?.toString() || "0"
 		return {
@@ -237,7 +246,9 @@ export class OrderFiller {
 	}
 
 	private async getTransactionRequestData(
-		request: FillOrderRequest, inverted: SimpleOrder
+		request: FillOrderRequest,
+		inverted: SimpleOrder,
+		options?: { disableCheckingBalances?: boolean }
 	): Promise<OrderFillSendData> {
 		switch (request.order.type) {
 			case "RARIBLE_V1":
@@ -258,7 +269,10 @@ export class OrderFiller {
 					<OpenSeaV1OrderFillRequest>request
 				)
 			case "SEAPORT_V1":
-				return this.seaportHandler.getTransactionData(<SeaportV1OrderFillRequest>request)
+				return this.seaportHandler.getTransactionData(
+          <SeaportV1OrderFillRequest>request,
+          { disableCheckingBalances: options?.disableCheckingBalances }
+				)
 			case "LOOKSRARE":
 				return this.looksrareHandler.getTransactionData(<LooksrareOrderFillRequest>request)
 			case "LOOKSRARE_V2":

packages/ethereum/sdk/src/order/fill-order/seaport-utils/balance-and-approval-check.ts

@@ -219,12 +219,14 @@ export const validateBasicFulfillBalancesAndApprovals = ({
 	timeBasedItemParams,
 	offererOperator,
 	fulfillerOperator,
+	disableCheckingBalances,
 }: {
 	offererBalancesAndApprovals: BalancesAndApprovals;
 	fulfillerBalancesAndApprovals: BalancesAndApprovals;
 	timeBasedItemParams: TimeBasedItemParams;
 	offererOperator: string;
 	fulfillerOperator: string;
+	disableCheckingBalances?: boolean;
 } & Pick<OrderParameters, "offer" | "consideration">) => {
 	validateOfferBalancesAndApprovals({
 		offer,
@@ -253,7 +255,7 @@ export const validateBasicFulfillBalancesAndApprovals = ({
     	operator: fulfillerOperator,
     })
 
-	if (insufficientBalances.length > 0) {
+	if (!disableCheckingBalances && insufficientBalances.length > 0) {
 		throw new Error(
 			"The fulfiller does not have the balances needed to fulfill."
 		)
@@ -272,6 +274,7 @@ export const validateStandardFulfillBalancesAndApprovals = ({
 	timeBasedItemParams,
 	offererOperator,
 	fulfillerOperator,
+	disableCheckingBalances,
 }: Pick<OrderParameters, "offer" | "consideration"> & {
 	offerCriteria: InputCriteria[];
 	considerationCriteria: InputCriteria[];
@@ -280,6 +283,7 @@ export const validateStandardFulfillBalancesAndApprovals = ({
 	timeBasedItemParams: TimeBasedItemParams;
 	offererOperator: string;
 	fulfillerOperator: string;
+	disableCheckingBalances?: boolean;
 }) => {
 	validateOfferBalancesAndApprovals({
 		offer,
@@ -313,7 +317,7 @@ export const validateStandardFulfillBalancesAndApprovals = ({
     	operator: fulfillerOperator,
     })
 
-	if (insufficientBalances.length > 0) {
+	if (!disableCheckingBalances && insufficientBalances.length > 0) {
 		throw new Error(
 			"The fulfiller does not have the balances needed to fulfill."
 		)

packages/ethereum/sdk/src/order/fill-order/seaport-utils/fulfill-advance-wrapper.ts

@@ -28,6 +28,7 @@ export async function getFulfillAdvancedOrderWrapperData({
 	conduitKey,
 	recipientAddress,
 	seaportContract,
+	disableCheckingBalances,
 }: {
 	order: Order;
 	unitsToFill?: BigNumberValue;
@@ -46,6 +47,7 @@ export async function getFulfillAdvancedOrderWrapperData({
 	recipientAddress: string;
 	timeBasedItemParams: TimeBasedItemParams;
 	seaportContract: EthereumContract,
+	disableCheckingBalances?: boolean;
 }) {
 	// If we are supplying units to fill, we adjust the order by the minimum of the amount to fill and
 	// the remaining order left to be fulfilled
@@ -105,6 +107,7 @@ export async function getFulfillAdvancedOrderWrapperData({
 		timeBasedItemParams,
 		offererOperator,
 		fulfillerOperator,
+		disableCheckingBalances,
 	})
 
 	const orderAccountingForTips: OrderStruct = {

packages/ethereum/sdk/src/order/fill-order/seaport-utils/seaport-utils.ts

@@ -53,7 +53,11 @@ export async function fulfillOrder(
 	ethereum: Ethereum,
 	send: SendFunction,
 	simpleOrder: SimpleSeaportV1Order,
-	{ tips, unitsToFill }: {tips?: TipInputItem[], unitsToFill?: BigNumberValue}
+	{ tips, unitsToFill, disableCheckingBalances }: {
+		tips?: TipInputItem[],
+		unitsToFill?: BigNumberValue,
+		disableCheckingBalances?: boolean
+	}
 ) {
 	const seaportContract = createSeaportV14Contract(ethereum, toAddress(simpleOrder.data.protocol))
 	const order = convertAPIOrderToSeaport(simpleOrder)
@@ -134,6 +138,7 @@ export async function fulfillOrder(
 			timeBasedItemParams,
 			offererOperator,
 			fulfillerOperator,
+			disableCheckingBalances,
 		})
 		return getfulfillBasicOrderData({
 			order: sanitizedOrder,
@@ -191,6 +196,7 @@ export async function approveBeforeBasicFulfillOrder(
 		timeBasedItemParams,
 		offererOperator,
 		fulfillerOperator,
+		disableCheckingBalances,
 	}: {
 		ethereum: Ethereum,
 		send: SendFunction,
@@ -201,6 +207,7 @@ export async function approveBeforeBasicFulfillOrder(
 		timeBasedItemParams: TimeBasedItemParams;
 		offererOperator: string;
 		fulfillerOperator: string;
+		disableCheckingBalances?: boolean;
 	}) {
 	const { offer, consideration } = order.parameters
 
@@ -214,6 +221,7 @@ export async function approveBeforeBasicFulfillOrder(
 		timeBasedItemParams,
 		offererOperator,
 		fulfillerOperator,
+		disableCheckingBalances,
 	})
 
 	const approvalActions = await getApprovalActions(

packages/ethereum/sdk/src/order/fill-order/seaport-utils/seaport-wrapper-utils.ts

@@ -34,11 +34,13 @@ export async function prepareSeaportExchangeData(
 		unitsToFill,
 		encodedFeesValue,
 		totalFeeBasisPoints,
+		disableCheckingBalances,
 	}: {
 		unitsToFill?: BigNumberValue
 		// converted to single uint fee value, values should be in right order in case of use for batch purchase
 		encodedFeesValue: BigNumber,
 		totalFeeBasisPoints: number,
+		disableCheckingBalances?: boolean;
 	}
 ): Promise<PreparedOrderRequestDataForExchangeWrapper> {
 	const seaportContract = getSeaportContract(ethereum, toAddress(simpleOrder.data.protocol))
@@ -122,6 +124,7 @@ export async function prepareSeaportExchangeData(
 		conduitKey,
 		recipientAddress,
 		seaportContract,
+		disableCheckingBalances,
 	})
 
 	const valueForSending = calcValueWithFees(toBigNumber(fulfillOrdersData.value), totalFeeBasisPoints)

packages/ethereum/sdk/src/order/fill-order/seaport.ts

@@ -90,17 +90,14 @@ export class SeaportOrderHandler {
 	}
 	async getTransactionData(
 		request: SeaportV1OrderFillRequest,
+		requestOptions?: { disableCheckingBalances?: boolean },
 	): Promise<OrderFillSendData> {
 		const ethereum = getRequiredWallet(this.ethereum)
 		const { order } = request
 		if (order.start === undefined || order.end === undefined) {
 			throw new Error("Order should includes start/end fields")
 		}
 
-		if (request.order.taker) {
-			throw new Error("You can't fill private orders")
-		}
-
 		const { unitsToFill, takeIsNft } = getUnitsToFill(request)
 
 		let tips: TipInputItem[] | undefined = []
@@ -128,6 +125,7 @@ export class SeaportOrderHandler {
 			{
 				unitsToFill,
 				tips,
+				disableCheckingBalances: requestOptions?.disableCheckingBalances,
 			},
 		)
 
@@ -157,6 +155,7 @@ export class SeaportOrderHandler {
 		request: SeaportV1OrderFillRequest,
 		originFees: Part[] | undefined,
 		feeValue: BigNumber,
+		options?: { disableCheckingBalances?: boolean },
 	): Promise<PreparedOrderRequestDataForExchangeWrapper> {
 		if (!this.ethereum) {
 			throw new Error("Wallet undefined")
@@ -194,6 +193,7 @@ export class SeaportOrderHandler {
 				unitsToFill: unitsToFill,
 				encodedFeesValue: feeValueWithCurrency,
 				totalFeeBasisPoints: totalFeeBasisPoints,
+				disableCheckingBalances: options?.disableCheckingBalances,
 			},
 		)
 	}

packages/transaction-backend/jest.setup.js

@@ -19,4 +19,4 @@ process.env.ETEHREUM_RPC_URL="https://dev-ethereum-node.rarible.com"
 
 process.env.MANTLE_SDK_ENV="dev-mantle"
 process.env.MANTLE_API_URL="https://dev-mantle-api.rarible.org"
-process.env.MANTLE_RPC_URL="https://dev-mantle-node.rarible.com"
+process.env.MANTLE_RPC_URL="https://dev-mantle-node.rarible.com"

packages/transaction-backend/src/orders/fill.test.ts

@@ -52,7 +52,7 @@ describe.skip("get buy transaction", () => {
 			takeAssetType: {
 				assetClass: "ETH",
 			},
-			priceDecimal: "0.000000000000000002",
+			priceDecimal: "0.0002",
 			payouts: [],
 			originFees: [],
 			end: Date.now() + 1000 * 60 * 60 * 24 * 30,
@@ -85,7 +85,7 @@ describe.skip("get buy transaction", () => {
 		}
 		await web3Buyer.eth.sendSignedTransaction(signedBuyerTx.rawTransaction)
 
-		await retry(5, 2000, async () => {
+		await retry(10, 3000, async () => {
 			await sdkItemOwner.apis.nftOwnership.getNftOwnershipById({
 				ownershipId: `${mintResult.itemId}:${buyerAddress}`,
 			})
@@ -123,7 +123,7 @@ describe.skip("get buy transaction", () => {
 			takeAssetType: {
 				assetClass: "ETH",
 			},
-			priceDecimal: "0.000000000000000002",
+			priceDecimal: "0.0002",
 			payouts: [],
 			originFees: [],
 			end: Date.now() + 1000 * 60 * 60 * 24 * 30,
@@ -162,4 +162,5 @@ describe.skip("get buy transaction", () => {
 		})
 
 	})
+
 })