add: no_send option to prevent transaction sending on-chain (#12)

* add: no_send option to prevent transaction sending on-chain * remove: no_send option from service config * refactor: pass no_send option in request body for each request
rarimo · Dec 23, 2024 · e80278f · e80278f
1 parent fecac50
commit e80278f
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/docs/spec/paths/integrations@registration-relayer@v1@register.yaml b/docs/spec/paths/integrations@registration-relayer@v1@register.yaml
@@ -18,6 +18,10 @@ post:
               properties:
                 tx_data:
                   type: string
+                no_send:
+                  type: bool
+                  description: Flag indicates whether transaction should be sent on-chain
+                  example: true
                 destination:
                   type: string
                   example: "0xC0B09085Fa2ad3A8BbF96494B8d5cd10702FE20d"

diff --git a/internal/service/handlers/registration.go b/internal/service/handlers/registration.go
@@ -84,15 +84,13 @@ func Registration(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	tx, err := sendTx(r, &txd, &registrationAddress)
+	tx, err := sendTx(r, &txd, &registrationAddress, req.Data.NoSend)
 	if err != nil {
 		Log(r).WithError(err).Error("failed to send tx")
 		ape.RenderErr(w, problems.InternalError())
 		return
 	}
 
-	RelayerConfig(r).IncrementNonce()
-
 	ape.Render(w, newTxResponse(tx))
 }
 
@@ -130,12 +128,17 @@ func confGas(r *http.Request, txd *txData, receiver *common.Address) (err error)
 	return nil
 }
 
-func sendTx(r *http.Request, txd *txData, receiver *common.Address) (tx *types.Transaction, err error) {
+func sendTx(r *http.Request, txd *txData, receiver *common.Address, noSend bool) (tx *types.Transaction, err error) {
 	tx, err = signTx(r, txd, receiver)
 	if err != nil {
 		return nil, fmt.Errorf("failed to sign new tx: %w", err)
 	}
 
+	if noSend {
+		Log(r).WithField("hash", tx.Hash().String()).Warn("transaction sending disabled")
+		return tx, nil
+	}
+
 	if err = RelayerConfig(r).RPC.SendTransaction(r.Context(), tx); err != nil {
 		if strings.Contains(err.Error(), "nonce") {
 			if err = RelayerConfig(r).ResetNonce(RelayerConfig(r).RPC); err != nil {
@@ -155,6 +158,8 @@ func sendTx(r *http.Request, txd *txData, receiver *common.Address) (tx *types.T
 		}
 	}
 
+	RelayerConfig(r).IncrementNonce()
+
 	return tx, nil
 }
 

diff --git a/internal/service/handlers/transit_state.go b/internal/service/handlers/transit_state.go
@@ -35,7 +35,7 @@ func TransitState(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	tx, err := sendTx(r, &txd, RelayerConfig(r).LightweightStateAddress)
+	tx, err := sendTx(r, &txd, RelayerConfig(r).LightweightStateAddress, false)
 	if err != nil {
 		Log(r).WithError(err).Error("failed to send tx")
 		ape.RenderErr(w, problems.InternalError())

diff --git a/internal/service/requests/registration.go b/internal/service/requests/registration.go
@@ -17,6 +17,7 @@ var (
 
 type RegistrationRequestData struct {
 	TxData      string  `json:"tx_data"`
+	NoSend      bool    `json:"no_send"`
 	Destination *string `json:"destination,omitempty"`
 }