🔥 quit saving code_challenge

ras0q · Feb 7, 2023 · fb54f54 · fb54f54
1 parent 5e2415d
commit fb54f54
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/example/webapp/main.go b/example/webapp/main.go
@@ -45,6 +45,14 @@ func authorizeHandler(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	session, err := globalManager.RetrieveSession(w, r)
+	if err != nil {
+		handleInternalServerError(w, err)
+		return
+	}
+
+	session.Set(codeVerifierKey, codeVerifier)
+
 	codeChallengeMethod := traqoauth2.CodeChallengeMethod(r.URL.Query().Get("method"))
 	if codeChallengeMethod == "" {
 		codeChallengeMethod = traqoauth2.CodeChallengePlain
@@ -56,16 +64,6 @@ func authorizeHandler(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	session, err := globalManager.RetrieveSession(w, r)
-	if err != nil {
-		handleInternalServerError(w, err)
-		return
-	}
-
-	session.Set(codeVerifierKey, codeVerifier)
-	session.Set(codeChallengeKey, codeChallenge)
-	session.Set(codeChallengeMethodKey, codeChallengeMethod)
-
 	authCodeURL := conf.AuthCodeURL(
 		r.URL.Query().Get("state"),
 		traqoauth2.WithCodeChallenge(codeChallenge),
@@ -173,8 +171,6 @@ const (
 	sessionName string = "traq-oauth2-example"
 
 	codeVerifierKey        sessionKey = "code_verifier"
-	codeChallengeKey       sessionKey = "code_challenge"
-	codeChallengeMethodKey sessionKey = "code_challenge_method"
 	userKey                sessionKey = "user"
 )