The _longest_encoded_length method

[bvahdat]

Throughout the book the _longest_encoded_length method has been implemented as:

def _longest_encoded_length(self):
    max_length = 0
    for encoded_text in self.encoded_texts:
        encoded_length = len(encoded_text)
        if encoded_length > max_length:
            max_length = encoded_length
    return max_length

Which returns the longest encoded_text in self.encoded_texts.

Question: would it make sense to achieve the same using a more pythonic approach?

def _longest_encoded_length(self):
    return max(len(encoded_text) for encoded_text in self.encoded_texts)

I could provide a PR if requested.

[rasbt]

Good call. I may have done it the verbose way to make it more readable, but I generally like the more pythonic approach you highlighted. That's imho how it should be done. Unfortunately, I prefer not to change the code because it would otherwise introduce a difference to the book, which could confuse readers. However, I think it's a good idea to add your suggestion via a code comment. Please feel free to open a PR if you have time (otherwise, no worries, I am also happy to do it, just let me know). Thanks for the suggestion in any case!

[bvahdat]

Thanks @rasbt for your feedback 👍 Please go ahead with adding a comment.

BTW you've REALLY done a great job with your book 💯

Thanks!

[rasbt]

Thanks for the kind words, I appreciate it. And sure, I will add it. I am just seeing that I also used the more pythonic approach in Ch07:

    # Find the longest sequence in the batch
    batch_max_length = max(len(item)+1 for item in batch)

So, I'm not sure why I did it so verbosely in chapter 6