[minor] typo & comments #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- safe -> save - commenting code: batch_size, seq_len = in_idx.shape
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rasbt
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put line of code
batch_size, seq_len = in_idx.shapeas comment since we don't need these dims anymore (for absolute pos embs) now that we use RoPEAdded a
# NEWin GQA__init__for the added lineassert num_heads % num_kv_groups == 0I wanted to PR the GPT-to-all-Llama main picture in
ch05/07_gpt_to_llamawith my edit below, which include weights tying for Llama 3.2 but pictures are coming from your own website, so i thought it would be best you're the one taking care of it (having the same source)