Skip to content

Issues upgrading to PHP8 #41

Open
Open
@a4992214

Description

@a4992214

Migrating to PHP8 will cause a problem with the use of the class name "Match".
Recommend you change the three occurrences to "HtmlDiffMatch".

Line 342 changed to:
$matches[] = new HtmlDiffMatch( count( $this->oldWords ), count( $this->newWords ), 0 );

Line 360:

if( count( $match ) != 0 ) {
	$operations[] = new Operation( 'equal', $match->StartInOld, $match->EndInOld(), $match->StartInNew, $match->EndInNew() );
}

changed to

$operations[] = new Operation( 'equal', $match->StartInOld, $match->EndInOld(), $match->StartInNew, $match->EndInNew() );

Line 428 changed to:
return $bestMatchSize != 0 ? new HtmlDiffMatch( $bestMatchInOld, $bestMatchInNew, $bestMatchSize ) : null;

Line 432 changed to:
class HtmlDiffMatch {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions