Merge pull request #5 from rashmichandrashekar/rashmi/pr-comments

rashmichandrashekar · Sep 8, 2021 · fd262e9 · fd262e9
2 parents fe3b4f2 + f5e999d
commit fd262e9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/receiver/prometheusreceiver/config.go b/receiver/prometheusreceiver/config.go
@@ -195,7 +195,7 @@ func (cfg *Config) Validate() error {
 						}
 						continue
 					}
-					fmt.Printf("WARNING: file %q for file_sd in scrape job %q does not exist\n", file, sc.JobName)
+					return fmt.Errorf("file %q for file_sd in scrape job %q does not exist\n", file, sc.JobName)
 				}
 			}
 		}

diff --git a/receiver/prometheusreceiver/testdata/config_sd.yaml b/receiver/prometheusreceiver/testdata/config_sd.yaml
@@ -5,7 +5,7 @@ receivers:
       - job_name: file
         file_sd_configs:
         - files:
-          - 'dummy.json'
+          - './testdata/dummy.json'
       - job_name: k8s
         kubernetes_sd_configs:
         - role: node

diff --git a/receiver/prometheusreceiver/testdata/dummy.json b/receiver/prometheusreceiver/testdata/dummy.json
@@ -0,0 +1 @@
+[]
-Original file line number
+Diff line change
@@ Expand Up / @@ -195,7 +195,7 @@ func (cfg *Config) Validate() error { @@
     						}
     						continue
     					}
-    					fmt.Printf("WARNING: file %q for file_sd in scrape job %q does not exist\n", file, sc.JobName)
+    					return fmt.Errorf("file %q for file_sd in scrape job %q does not exist\n", file, sc.JobName)
     				}
     			}
     		}
@@ Expand Down @@