This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 34
csi-* images are outdated, invalid build.make.patch failing builds #205
Labels
bug
Something isn't working
Comments
5 tasks
zamnuts
added a commit
to zamnuts/multi-arch-images
that referenced
this issue
Feb 22, 2021
…spbernetes#205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-resizer#122 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com>
zamnuts
added a commit
to zamnuts/multi-arch-images
that referenced
this issue
Feb 22, 2021
In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-resizer#122 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com>
xunholy
pushed a commit
that referenced
this issue
Feb 22, 2021
In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-resizer#122 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com>
zamnuts
added a commit
to zamnuts/multi-arch-images
that referenced
this issue
Feb 22, 2021
…pbernetes#205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-attacher#268 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com>
zamnuts
added a commit
to zamnuts/multi-arch-images
that referenced
this issue
Feb 22, 2021
…aspbernetes#205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-provisioner#515 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com>
zamnuts
added a commit
to zamnuts/multi-arch-images
that referenced
this issue
Feb 22, 2021
…patibility, raspbernetes#205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-snapshotter#437 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com>
zamnuts
added a commit
to zamnuts/multi-arch-images
that referenced
this issue
Feb 22, 2021
…aspbernetes#205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/node-driver-registrar#118 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com>
5 tasks
xunholy
pushed a commit
that referenced
this issue
Feb 22, 2021
* fix(csi-external-attacher): make patch for v3.1.0+ compatibility, #205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-attacher#268 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com> * fix(csi-external-provisioner): make patch for v2.1.0+ compatibility, #205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-provisioner#515 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com> * fix(csi-external-snapshotter): make patch for v3.0.3+ and v4.0.0+ compatibility, #205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-snapshotter#437 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com> * fix(csi-node-driver-registrar): make patch for v2.1.0+ compatibility, #205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/node-driver-registrar#118 Signed-off-by: Andrew Zammit <zammit.andrew@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Details
What steps did you take and what happened:
During a recent rook-ceph install, I was verifying CSI image versions in raspbernetes compared with their upstreams on quay (kubernetes-csi publishes to both GCR and quay*). All CSI images were outdated. Originally I thought it was just one, so opened PR #204 to fix
csi-external-resizer
, and then only afterwards realized all were failing for the same reason:Image list and their respective failed runs:
All builds failing :)
What did you expect to happen:
Stay up-to-date for the following images:
All builds to succeed :)
Anything else you would like to add:
I'd be happy to contribute individual fixes for each in unique PRs, but am unsure how to test / don't have the means. I'd like to get PR #204 through first to see it successfully publish (and work as expected), before contributing the other PRs. I'm unsure if
build.make
is the only problem. LMK if you want these in distinct PRs, or clubbed under one, given that it appears to all be the same bug.Additionally, it looks like the last few versions are missing, despite some of the
.version
files being updated. We can get the fix in, then make incremental commits to fill in the missing raspbernetes published versions, or just publish the latest and consider the ones missing gone forever.The text was updated successfully, but these errors were encountered: